refactor(api/accounting/cost): apply map.entry().or_default/insert() …

…pattern

Signed-off-by: Sandro-Alessio Gierens <[email protected]>

api/src/routes/accounting/server_consumption/get.rs

@@ -79,15 +79,11 @@ pub async fn calculate_server_consumption_for_server(
         }
     }
     for state in states {
-        // TODO: this contains_key insert pattern can be replaced with entry().or_insert()
-        if !consumption.contains_key(&state.flavor_name) {
-            consumption.insert(state.flavor_name.clone(), 0.0);
-        }
+        let entry = consumption.entry(state.flavor_name).or_default();
         if !CONSUMING_STATES.contains(&state.status.as_str()) {
             continue;
         }
-        *consumption.get_mut(&state.flavor_name).unwrap() +=
-            (state.end.unwrap() - state.begin).num_seconds() as f64;
+        *entry += (state.end.unwrap() - state.begin).num_seconds() as f64;
     }
     // TODO:
     Ok(consumption)
@@ -118,13 +114,9 @@ pub async fn calculate_server_consumption_for_user(
     let mut server_state_map: HashMap<String, Vec<ServerState>> =
         HashMap::new();
     for state in states {
-        // TODO: this contains_key insert pattern can be replaced with entry().or_insert()
-        if !server_state_map.contains_key(state.instance_id.as_str()) {
-            server_state_map.insert(state.instance_id.clone(), Vec::new());
-        }
         server_state_map
-            .get_mut(state.instance_id.as_str())
-            .unwrap()
+            .entry(state.instance_id.clone())
+            .or_default()
             .push(state);
     }
 
@@ -145,11 +137,7 @@ pub async fn calculate_server_consumption_for_user(
 
     for server_consumption in consumption.servers.values() {
         for (flavor, value) in server_consumption {
-            // TODO: this contains_key insert pattern can be replaced with entry().or_insert()
-            if !consumption.total.contains_key(flavor.as_str()) {
-                consumption.total.insert(flavor.clone(), 0.0);
-            }
-            *consumption.total.get_mut(flavor.as_str()).unwrap() += value;
+            *consumption.total.entry(flavor.clone()).or_default() += value;
         }
     }
 
@@ -193,11 +181,7 @@ pub async fn calculate_server_consumption_for_project(
         };
 
         for (flavor, value) in user_consumption.total.clone() {
-            // TODO: this contains_key insert pattern can be replaced with entry().or_insert()
-            if !consumption.total.contains_key(flavor.as_str()) {
-                consumption.total.insert(flavor.clone(), 0.0);
-            }
-            *consumption.total.get_mut(flavor.as_str()).unwrap() += value;
+            *consumption.total.entry(flavor.clone()).or_default() += value;
         }
 
         consumption
@@ -244,11 +228,7 @@ pub async fn calculate_server_consumption_for_all(
             };
 
         for (flavor, value) in project_consumption.total.clone() {
-            // TODO: this contains_key insert pattern can be replaced with entry().or_insert()
-            if !consumption.total.contains_key(flavor.as_str()) {
-                consumption.total.insert(flavor.clone(), 0.0);
-            }
-            *consumption.total.get_mut(flavor.as_str()).unwrap() += value;
+            *consumption.total.entry(flavor.clone()).or_default() += value;
         }
 
         consumption