Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add profile_idx_name as member to Thicket class #235

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Add profile_idx_name as member to Thicket class #235

wants to merge 5 commits into from

Conversation

michaelmckinsey1
Copy link
Collaborator

@michaelmckinsey1 michaelmckinsey1 commented Jan 22, 2025 •
edited
Loading

Resolves #232. Enables replacing the "profile" index.

@michaelmckinsey1 michaelmckinsey1 added area-tests Issues and PRs involving Thicket's automated tests area-thicket Issues and PRs involving Thicket's core Thicket datastructure and associated classes priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-feature Requests for new features or PRs which implement new features labels Jan 22, 2025
@michaelmckinsey1 michaelmckinsey1 self-assigned this Jan 22, 2025
@michaelmckinsey1 michaelmckinsey1 mentioned this pull request Jan 23, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slabasan slabasan Awaiting requested review from slabasan

@ilumsden ilumsden Awaiting requested review from ilumsden

At least 1 approving review is required to merge this pull request.

Assignees

@michaelmckinsey1 michaelmckinsey1

Labels
area-tests Issues and PRs involving Thicket's automated tests area-thicket Issues and PRs involving Thicket's core Thicket datastructure and associated classes priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-feature Requests for new features or PRs which implement new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace hardcoded logic for the "profile" index level with a member variable
1 participant
@michaelmckinsey1