Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statsframe Cache Pickle Serialization Fix #207

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Statsframe Cache Pickle Serialization Fix #207

merged 1 commit into from
Aug 26, 2024

Conversation

Yejashi
Copy link
Collaborator

@Yejashi Yejashi commented Aug 26, 2024 •
edited
Loading

This pr resolves a serialization issue caused by the statsframe_ops_cache.

The error is presented as follows:

PicklingError: Can't pickle <function mean at 0x7fff9e7c7920>: it's not the same object as thicket.stats.mean.mean

The current fix it to reset the cache at every to_pickle call.

@Yejashi Yejashi changed the title Statsfrmae Cache Pickle Serialization Fix Statsframe Cache Pickle Serialization Fix Aug 26, 2024
ilumsden
ilumsden approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@ilumsden ilumsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pearce8 this is ready for your review

@ilumsden ilumsden added area-thicket Issues and PRs involving Thicket's core Thicket datastructure and associated classes priority-normal Normal priority issues and PRs status-approved No more revisions are required on this PR and it is ready for merge type-bug Identifies bugs in issues and identifies bug fixes in PRs labels Aug 26, 2024
@pearce8 pearce8 merged commit 29197ea into LLNL:develop Aug 26, 2024
4 checks passed
@slabasan slabasan added this to the 2024.2.0 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilumsden ilumsden ilumsden approved these changes

@pearce8 pearce8 pearce8 approved these changes

Assignees

@Yejashi Yejashi

Labels
area-thicket Issues and PRs involving Thicket's core Thicket datastructure and associated classes priority-normal Normal priority issues and PRs status-approved No more revisions are required on this PR and it is ready for merge type-bug Identifies bugs in issues and identifies bug fixes in PRs
Projects
None yet
Milestone
2024.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Yejashi @pearce8 @ilumsden @slabasan