Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hardcoded logic for the "profile" index level with a member variable #232

Open
ilumsden opened this issue Jan 13, 2025 · 0 comments · May be fixed by #235
Open

Replace hardcoded logic for the "profile" index level with a member variable #232

ilumsden opened this issue Jan 13, 2025 · 0 comments · May be fixed by #235
Assignees
Labels
area-thicket Issues and PRs involving Thicket's core Thicket datastructure and associated classes priority-normal Normal priority issues and PRs type-internal-cleanup PRs or Issues related to the structure of the codebase, directories, and refactors

Comments

@ilumsden
Copy link
Collaborator

Right now, a lot of the logic around the "profile" index level is hardcoded based on the "profile" name. Instead, the logic should be based around a member variable, such as Thicket.profile_idx_name. This will give us more flexibility to handle alternate names/name changes in the future. It will also allow us to handle replacing the "profile" index level with another.

@ilumsden ilumsden added area-thicket Issues and PRs involving Thicket's core Thicket datastructure and associated classes priority-normal Normal priority issues and PRs type-internal-cleanup PRs or Issues related to the structure of the codebase, directories, and refactors labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-thicket Issues and PRs involving Thicket's core Thicket datastructure and associated classes priority-normal Normal priority issues and PRs type-internal-cleanup PRs or Issues related to the structure of the codebase, directories, and refactors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants