Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a macro to wrap add_executable #651

Merged
merged 7 commits into from
Jan 23, 2025

Conversation

balos1
Copy link
Member

@balos1 balos1 commented Jan 23, 2025

This will be used to allow us to easily exclude some examples that do not support complex arithmetic from being built @drreynolds.

Copy link
Member

@gardner48 gardner48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor things, otherwise this looks good

cmake/macros/SundialsAddNvectorBenchmark.cmake Outdated Show resolved Hide resolved
external/sundials-addon-example Outdated Show resolved Hide resolved
test/answers Outdated Show resolved Hide resolved
Copy link
Member

@gardner48 gardner48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion since the macros are functions now

cmake/macros/SundialsAddExecutable.cmake Outdated Show resolved Hide resolved
cmake/macros/SundialsAddExecutable.cmake Outdated Show resolved Hide resolved
@gardner48 gardner48 merged commit 32b87ca into develop Jan 23, 2025
47 checks passed
@gardner48 gardner48 deleted the feature/sundials_add_executable branch January 23, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants