Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance Testing #287

Merged
merged 46 commits into from
Sep 26, 2024
Merged

Performance Testing #287

merged 46 commits into from
Sep 26, 2024

Conversation

ldowen
Copy link
Collaborator

@ldowen ldowen commented Jul 17, 2024 •
edited
Loading

Summary

  • This PR adds performance testing
  • It does the following:
    • Updates the Caliper version
    • Includes Adiak as a TPL
    • Python wraps Adiak and Caliper calls
    • Allows target export for ENABLE_DEV_BUILD builds
    • Cleans up spack package file
    • Adds a test for the Adiak and Caliper methods
    • Adds documentation for using Caliper and Adiak
    • Provides a default Caliper timer configuration and output filenames

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#104)
  • LLNLSpheral PR has passed all tests.

@ldowen ldowen requested review from jmikeowen and mdavis36 July 17, 2024 20:57
@ldowen ldowen self-assigned this Jul 17, 2024
@ldowen ldowen marked this pull request as draft July 17, 2024 20:58
ldowen added 25 commits July 18, 2024 10:54
@ldowen
Start integrating Adiak
9c51f73
@ldowen
Merge branch 'develop' into feature/add_performance_testing
286985e
@ldowen
Added adiak_value functions and updated caliper.config
6dcc396
@ldowen
Merge branch 'develop' into feature/add_performance_testing
9f64517
@ldowen
Merge with develop
e365424
@ldowen
Merge branch 'develop' into feature/add_performance_testing
5b5ad91
@ldowen
Redid spheral spack package logic, added logic to automatically initi…
a334025 
…alize and finalize Adiak when modules are loaded or destroyed, added main timer around entire program, import Caliper using find_package, switched performance.ats with performance.py with atsExit routine, fixed build output bugs and quieted some output, changed caliper configuration to spot temporarily
@ldowen
Updated optparse to argparse, added singleton wrapp for the caliper c…
5acd124 
…onfigmanager that is python wrapped and initialized in SpheralOptionsParser and uninitialized when module is unloaded
@ldowen
Merge branch 'develop' into feature/add_performance_testing
b321563
@ldowen
Fixed bugs with TimerMgr singleton
60c61cd
@ldowen
Merge branch 'develop' into feature/add_performance_testing
6e42bbe
@ldowen
Added valgrind python suppression, removed & for accessing communicat…
cd3f889 
…or for adiak init
@ldowen
Fixed inconsistency in Communicator for non-MPI builds and added poin…
6b6628c 
…ter function to get null pointer for adiak
@ldowen
Moved MPI finalize to occur when SpheralUtilities exits (either throu…
d488e50 
…gh Caliper or the communicator), allow caliper_config to be turned off at runtime if necessary, moved the instance of TimerMgr into the functions to simplify the calls
@ldowen
Verify MPI finalize error inside communicator routine
229459e
@ldowen
Moved ifdefs in Communicator.hh
5a82358
@ldowen
Forgot to include DBC.hh
03503b6
@ldowen
Added more checks for mpi finalize, moved communicator routines to cc…
da9539e 
… file
@ldowen
Added timer test script and changed CMake logic for making tests, add…
92e9706 
…ed config and filename caliper variables
@ldowen
Added warning for caliper configurations provided to incorrect builds…
5b46839 
…, added documentation, updated copyright for docs to 2024
@ldowen
Fix bug with getting caliperreader from TPL
c010fb7
@ldowen
Fixed timer test to accomodate issue with caliperreader
b4a6e92
@ldowen
Merge branch 'develop' into feature/add_performance_testing
b57bfd9
@ldowen
Merge branch 'develop' into feature/add_performance_testing
d1bb75d
@ldowen
Added more default adiak values
cf674cd
@ldowen ldowen marked this pull request as ready for review September 10, 2024 23:31
jmikeowen
jmikeowen previously approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@jmikeowen jmikeowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me once all the tests have passed

mdavis36
mdavis36 previously approved these changes Sep 19, 2024
View reviewed changes
@ldowen
Added ability to specify a caliper configuration json file, remove hi…
bbc1706 
…ghwatermark spot configuration as it causes issues with LLNLSpheral tests
@ldowen ldowen merged commit 94bc035 into develop Sep 26, 2024
2 checks passed
@ldowen ldowen deleted the feature/add_performance_testing branch September 26, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdavis36 mdavis36 mdavis36 approved these changes

@jmikeowen jmikeowen jmikeowen approved these changes

Assignees

@ldowen ldowen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ldowen @jmikeowen @mdavis36