Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve a few hdf5 asan issues related to cleanup during exceptions #1304

Merged
merged 24 commits into from
Jul 20, 2024

Conversation

cyrush
Copy link
Member

@cyrush cyrush commented Jul 19, 2024

No description provided.

@cyrush cyrush changed the title resolve a few hdf5 asan issues related to cleanup during exception resolve a few hdf5 asan issues related to cleanup during exceptions Jul 19, 2024
@cyrush
Copy link
Member Author

cyrush commented Jul 19, 2024

TIL:

Building HDF5 in Debug mode will abort at process exec end if hdf5 fails to fully close all handles.

Our tests poke at hdf5 error conditions that leave hdf5 in a funky state.

You can use -DNDEBUG to avoid abort.

@cyrush
Copy link
Member Author

cyrush commented Jul 20, 2024

having a hard time suppressing mpi related leaks, here is an example:

==33334==ERROR: LeakSanitizer: detected memory leaks
2024-07-19T23:52:18.8699211Z Direct leak of 136 byte(s) in 1 object(s) allocated from:
2024-07-19T23:52:18.8700130Z     #0 0x558ff2f0bc33 in __interceptor_strdup (/home/runner/work/conduit/conduit/build/tests/blt_mpi_smoke+0x8bc33) (BuildId: 0b49975eba2a2bf13f82e575d76e271ff1254609)
2024-07-19T23:52:18.8700984Z     #1 0x7fc80cd6dd88  (<unknown module>)
2024-07-19T23:52:18.8701321Z     #2 0x502f6e6f72656c64  (<unknown module>)

Not sure I can just squash (<unknown_module>) ?

google/sanitizers#1731

In our case we are building all relevant TPLS with ASAN, so it might be ok to squash these unknown module + strdup.

In my containers, I can suppress PMPI_Init to solve these, but the github env is a little different.
Maybe just need to run in a custom container.

@cyrush cyrush merged commit 92e22b3 into develop Jul 20, 2024
26 checks passed
@cyrush cyrush deleted the task/2024_07_asan_pass branch July 20, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant