add gyre example and high level mesh bp examples driver #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinPrivitera
approved these changes
Jul 17, 2024
Comment on lines
+211
to
+212
| // desc is an output? | ||
| conduit::Node desc; |
There was a problem hiding this comment.
I don't think it is an output. Looking at the tests it looks like it is an optional input. Might want to consider how users could provide desc for this case when using this generate infrastructure.
Comment on lines
+201
to
+228
| def test_examples_generate_default_opts(self): | ||
| opts = conduit.Node() | ||
| blueprint.mesh.examples.generate_default_options(opts) | ||
| print(opts) | ||
| enames = ["braid", | ||
| "basic", | ||
| "strided_structured", | ||
| "grid", | ||
| "spiral", | ||
| "polytess", | ||
| "polychain", | ||
| "misc", | ||
| "adjset_uniform", | ||
| "gyre", | ||
| "julia", | ||
| "julia_nestsets_simple", | ||
| "julia_nestsets_complex", | ||
| "polystar", | ||
| "related_boundary", | ||
| "rz_cylinder", | ||
| "tiled", | ||
| "venn"] | ||
|
|
||
| for ename in enames: | ||
| opts = conduit.Node() | ||
| blueprint.mesh.examples.generate_default_options(opts,ename) | ||
| print(ename) | ||
| print(opts) |
There was a problem hiding this comment.
we don't want to baseline these?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.