Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding BabelSTREAM experiment class #526

Merged
merged 25 commits into from
Jan 24, 2025
Merged

Adding BabelSTREAM experiment class #526

merged 25 commits into from
Jan 24, 2025

Conversation

august-knox
Copy link
Collaborator

@august-knox august-knox commented Jan 6, 2025

Description

Adding babelstream experiment class. Contains rocm, openmp, and openmp variants. Caliper annotations also available. array sizing is set to an arbitrary value right now, and can be adjusted in future.

Dependencies: Currently using August's branch https://github.com/august-knox/BabelStream.git

Fixes issue(s): None

Type of Change

  • {x} Adding a system, benchmark, or experiment
  • {x} Modifying an existing system, benchmark, or experiment
  • { } Documentation update
  • { } Build/CI update
  • { } Benchpark core functionality

Checklist:

If adding/modifying a system:

  • { } Create a new directory for the system and a new system.py file
  • { } Add a new dry run unit test in .github/workflows
  • { } System appears in System Specifications table in docs catalogue section

If adding/modifying a benchpark:

  • {x} Add a new application.py and (maybe) package.py under a new directory
    for this benchmark
  • {x} Configure an experiment
  • { } Benchmark appears in Benchmarks and Experiments table in docs catalogue
    section

If adding/modifying a experiment:

  • {x} Extend experiment.py under existing directory for specific benchmark
  • {x} Define a single node and multi-node experiments

If adding/modifying core functionality:

  • { } Update docs
  • { } Update .github/workflows and .gitlab/ci unit tests (if needed)

@github-actions github-actions bot added experiment New or modified experiment ci CI, unit tests, GitHub actions application labels Jan 6, 2025
@august-knox august-knox requested a review from rfhaque January 6, 2025 21:35
@august-knox august-knox added the ready for review Ready for review label Jan 8, 2025
Comment on lines +24 to +25
git = "https://github.com/august-knox/BabelStream.git"
version("4.0", sha256="a9cd39277fb15d977d468435eb9b894f79f468233f0131509aa540ffda4f5953")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@august-knox Is it possible to upstream the caliperization to the main Babel repo?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can put together a PR in their repo

@rfhaque rfhaque merged commit 90e025f into develop Jan 24, 2025
7 checks passed
@rfhaque rfhaque deleted the experiment/babelstream branch January 24, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI, unit tests, GitHub actions experiment New or modified experiment ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants