Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes the logger test so that it no longer fails when importing
LOG_LEVEL
fromlogger.ts
. Previously, there was a mismatch betweenLOG_LEVEL
(a constant from@lit-protocol/constants
) andLogLevel
(an enum). This change ensures that both references can coexist, while favoringLOG_LEVEL
for future compatibility.Additionally, the test that checks creation timestamps (
should order logs based on logger creation timestamp
) has been corrected to compareloggerA.timestamp
andloggerB.timestamp
properly, instead of incorrectly matching a numeric timestamp against string IDs.Related Issue:
Type of change
How Has This Been Tested?
npx nx run logger:test --coverage
and all tests passed without TypeScript errors.LOG_LEVEL
can be imported, andLogLevel
still exists for backward compatibility.❯ yarn nx format:check --all yarn run v1.22.22 $ /Users/susumu/js-sdk/node_modules/.bin/nx format:check --all [warn] jsxBracketSameLine is deprecated. ✨ Done in 4.71s.
Checklist: