Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added test maps #55

Closed
wants to merge 3 commits into from
Closed

added test maps #55

wants to merge 3 commits into from

Conversation

marc-hanheide
Copy link
Member

just added two tmap2 format test maps for various debugging purposes. Loads int map_manager2 just fine.

@adambinch
Copy link
Collaborator

adambinch commented Feb 14, 2021

Not sure if this matters for this PR as im sure the format of the new map will continue to be updated as new features are implemented but thought i should point it out.
The config field for an edge has changed (in #54) from

      config:
        inflation_radius: 0.0
        recovery_behaviours_config: ''
        top_vel: 0.55

to

      config: 
      - namespace: param1_namespace                   
        name: param1_name
        value: param1_value
      - namespace: param2_namespace                 
        name: param2_name
        value: param2_value
      recovery_behaviours_config: ''

such that anything can be reconfigured when the edge is traversed. Recovery behaviours config is now its own thing.

@marc-hanheide
Copy link
Member Author

My main point is that we should have a valid test map in the repo and run a unit test to load it. So, any new PR that changes the map format should then also change the test map accordingly.

@marc-hanheide
Copy link
Member Author

the idea is still strong, the implementation is outdated. Should go into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants