[ArchSpace] Improve Space Creation and ensureBase #187
Annotations
7 errors and 43 warnings
|
Codespell
Process completed with exit code 1.
|
|
Black (Python)
Process completed with exit code 1.
|
|
Pylint:
src/Mod/BIM/ArchSpace.py#L685
Possibly using variable 'FreeCADGui' before assignment (possibly-used-before-assignment)
|
|
Pylint:
src/Mod/BIM/ArchSpace.py#L723
Possibly using variable 'QtGui' before assignment (possibly-used-before-assignment)
|
|
Pylint:
src/Mod/BIM/ArchSpace.py#L728
Possibly using variable 'QtCore' before assignment (possibly-used-before-assignment)
|
|
Pylint:
src/Mod/Draft/DraftGui.py#L1631
Instance of 'DraftToolBar' has no 'ui' member (no-member)
|
|
Pylint
Process completed with exit code 1.
|
|
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Codespell:
src/Mod/BIM/importers/importDAE.py#L169
occured ==> occurred
|
|
Black (Python):
src/Mod/Draft/draftmake/make_sketch.py#L1
would reformat src/Mod/Draft/draftmake/make_sketch.py
|
|
Black (Python):
src/Mod/BIM/importers/importDAE.py#L1
would reformat src/Mod/BIM/importers/importDAE.py
|
|
Black (Python):
src/Mod/BIM/ArchSpace.py#L1
would reformat src/Mod/BIM/ArchSpace.py
|
|
Black (Python):
src/Mod/Draft/DraftGui.py#L1
would reformat src/Mod/Draft/DraftGui.py
|
|
Pylint:
src/Mod/BIM/ArchSpace.py#L193
Line too long (106/100) (line-too-long)
|
|
Pylint:
src/Mod/BIM/ArchSpace.py#L221
Line too long (175/100) (line-too-long)
|
|
Pylint:
src/Mod/BIM/ArchSpace.py#L223
Line too long (146/100) (line-too-long)
|
|
Pylint:
src/Mod/BIM/ArchSpace.py#L225
Line too long (158/100) (line-too-long)
|
|
Pylint:
src/Mod/BIM/ArchSpace.py#L227
Line too long (158/100) (line-too-long)
|
|
Pylint:
src/Mod/BIM/ArchSpace.py#L229
Line too long (160/100) (line-too-long)
|
|
Pylint:
src/Mod/BIM/ArchSpace.py#L231
Line too long (180/100) (line-too-long)
|
|
Pylint:
src/Mod/BIM/ArchSpace.py#L233
Line too long (140/100) (line-too-long)
|
|
Pylint:
src/Mod/BIM/ArchSpace.py#L236
Line too long (151/100) (line-too-long)
|
|
Pylint:
src/Mod/BIM/ArchSpace.py#L238
Line too long (170/100) (line-too-long)
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L2095
Returning a void expression [-Wclazy-returning-void-expression]
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L2197
fmt::detail::specs_setter has copy-ctor but not dtor, copy-assignment [-Wclazy-rule-of-three]
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L2233
fmt::detail::dynamic_specs_handler has copy-ctor but not dtor, copy-assignment [-Wclazy-rule-of-three]
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3126
Pass small and trivially-copyable type by value (const signed char &) [-Wclazy-function-args-by-value]
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3127
Pass small and trivially-copyable type by value (const unsigned char &) [-Wclazy-function-args-by-value]
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3128
Pass small and trivially-copyable type by value (const short &) [-Wclazy-function-args-by-value]
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3129
Pass small and trivially-copyable type by value (const unsigned short &) [-Wclazy-function-args-by-value]
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3130
Pass small and trivially-copyable type by value (const long &) [-Wclazy-function-args-by-value]
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3131
Pass small and trivially-copyable type by value (const unsigned long &) [-Wclazy-function-args-by-value]
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3134
Pass small and trivially-copyable type by value (const std::nullptr_t &) [-Wclazy-function-args-by-value]
|
|
Clang-tidy:
src/Gui/CommandLink.cpp#L56
do not call c-style vararg functions [cppcoreguidelines-pro-type-vararg]
|
|
Clang-tidy:
src/Gui/CommandLink.cpp#L69
function 'StdCmdLinkMakeGroup::activated' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
|
|
Clang-tidy
note: the definition seen here
|
|
Clang-tidy
note: differing parameters are named here: ('iMsg'), in definition: ('option')
|
|
Clang-tidy:
src/Gui/CommandLink.cpp#L88
implicit conversion 'App::Document *' -> 'bool' [readability-implicit-bool-conversion]
|
|
Clang-tidy:
src/Gui/CommandLink.cpp#L112
statement should be inside braces [readability-braces-around-statements]
|
|
Clang-tidy:
src/Gui/CommandLink.cpp#L122
function 'activated' has cognitive complexity of 36 (threshold 25) [readability-function-cognitive-complexity]
|
|
Clang-tidy
note: +1, including nesting penalty of 0, nesting level increased to 1
|
|
Clang-tidy
note: +2, including nesting penalty of 1, nesting level increased to 2
|
|
Clang-tidy
note: expanded from macro 'FC_ERR'
|
|
Cpplint:
src/Gui/CommandLink.cpp#L51
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
|
Cpplint:
src/Gui/CommandLink.cpp#L587
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
|
|
Cpplint:
src/Gui/CommandLink.cpp#L744
Using C-style cast. Use static_cast<int>(...) instead [readability/casting] [4]
|
|
Cpplint:
src/Gui/CommandLink.cpp#L827
Using C-style cast. Use static_cast<int>(...) instead [readability/casting] [4]
|
|
Cpplint:
src/Gui/CommandLink.cpp#L231
Add #include <set> for set<> [build/include_what_you_use] [4]
|
|
Cpplint:
src/Gui/CommandLink.cpp#L371
Add #include <utility> for make_pair [build/include_what_you_use] [4]
|
|
Cpplint:
src/Gui/CommandLink.cpp#L397
Add #include <unordered_map> for unordered_map<> [build/include_what_you_use] [4]
|
Loading