Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: update FaultInjection api #31

Merged
merged 4 commits into from
Feb 1, 2024
Merged

enhance: update FaultInjection api #31

merged 4 commits into from
Feb 1, 2024

Conversation

Eikykun
Copy link
Collaborator

@Eikykun Eikykun commented Jan 30, 2024

No description provided.

@Eikykun Eikykun self-assigned this Jan 30, 2024
@Eikykun Eikykun changed the title echance: fault injection in no Mesh-Real-Endpoint header case enhance: fault injection in no Mesh-Real-Endpoint header case Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (59ffd7a) 42.89% compared to head (27692ff) 40.82%.

Files Patch % Lines
pkg/proxy/faultinjection/manager.go 44.92% 37 Missing and 1 partial ⚠️
pkg/proxy/faultinjection/injector.go 25.00% 18 Missing ⚠️
pkg/proxy/faultinjection/store.go 87.50% 2 Missing and 1 partial ⚠️
pkg/proxy/grpcserver/faultinject_handler.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   42.89%   40.82%   -2.07%     
==========================================
  Files          26       26              
  Lines        2928     2748     -180     
==========================================
- Hits         1256     1122     -134     
+ Misses       1561     1516      -45     
+ Partials      111      110       -1     
Flag Coverage Δ
unittests 40.82% <50.81%> (-2.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eikykun Eikykun changed the title enhance: fault injection in no Mesh-Real-Endpoint header case enhance: update FaultInjection api Jan 31, 2024
@Eikykun Eikykun requested a review from spring-young February 1, 2024 03:56
@Eikykun Eikykun merged commit 3bc3457 into main Feb 1, 2024
5 of 6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
@Eikykun Eikykun deleted the 240130-fj-fix branch July 10, 2024 11:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant