Revert change on config.xml #9718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed class for dropdown to form-select
changed class for rank dropdown to form-select
changed class to form-select
changed class to form-select
|
It fixes the issues with CKeditor but it will needed to fixed too with SCeditor |
xillibit
pushed a commit
that referenced
this pull request
Oct 16, 2024
* Update HtmlView.php Changed class for dropdown to form-select * Update UserModel.php changed class for rank dropdown to form-select * Update UserModel.php changed class to form-select * Update HtmlView.php changed class to form-select * Update TemplateController.php * Update config.xml * Update sceditor.js * Update TemplateController.php * Update x button on cke editor toolbar * Replace x.png by x_social.png
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #9717
Pull Request for Issue #9698
Summary of Changes
#9717 Revert change on config.xml and change 2 other files
#9698 Change plugin.js and change x.png to x_social.png
Testing Instructions
See my comments on issue #9717
As far as I could test, the changes I made are working.
Change x/plugin.js and renaming image allows to hide x from editor toolbar