Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Remove commented code from elements #12189

Merged
merged 8 commits into from
Mar 15, 2024

Conversation

rfaasse
Copy link
Contributor

@rfaasse rfaasse commented Mar 15, 2024

📝 Description
This PR removes commented code as flagged by SonarCloud and implements a few other quick wins to remove element code smells.

@@ -74,8 +74,6 @@ void TransientPwElement<TDim, TNumNodes>::CalculateDampingMatrix(MatrixType& rDa
{
KRATOS_TRY

// Rayleigh Method (Damping Matrix = alpha*M + beta*K)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we only return a zero matrix here, I removed the comment

@rfaasse rfaasse requested a review from avdg81 March 15, 2024 08:59
@rfaasse rfaasse enabled auto-merge (squash) March 15, 2024 14:14
Copy link
Contributor

@avdg81 avdg81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clear cleanup. Thanks for reducing the noise levels in this part of the code base.

@rfaasse rfaasse merged commit 7f8ccdf into master Mar 15, 2024
15 of 16 checks passed
@rfaasse rfaasse deleted the geo/remove-commented-code-from-elements branch March 15, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants