Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just one example from the codebase. Why are so many APIs
expect
and why do we even try to usetypealias
at all? This makes it more difficult to define a nice API for Kotlin and it causes lots of code repetition. It's even impossible to usesealed interface/class
withexpect/actual
because the multiplatform code lives in different modules (see #173, #177 and #175 for how this can be useful).I think it would be much better to separate the
expect
APIs and make theminternal
and expose a nice and clear non-expect basedpublic
API (which can call theinternal expect
API inside).What do you think?