Rename to camelCase support in compiler plugin #1029
Conversation
Jolanrensen
added
the
Compiler plugin
| class RenameToCamelCaseClause : AbstractSchemaModificationInterpreter() { | ||
| val Arguments.receiver: RenameClauseApproximation by arg() | ||
|
|
||
| override fun Arguments.interpret(): PluginDataFrameSchema { |
There was a problem hiding this comment.
i'd suggest convert selected columns to path and receiver.df.asDataFrame().rename { paths }.toCamelCase().toPluginDataFrameSchema()
There was a problem hiding this comment.
that's easier indeed
There was a problem hiding this comment.
and it promotes the idea that the original function solves the compiler plugin part :) which is great. I just need to become a bit more comfortable with the helper functions available to me in the compiler plugin module, but I'll get there :)
| ) | ||
| val renamed = df.renameToCamelCase() | ||
|
|
||
| // Verify extension properties |
There was a problem hiding this comment.
this is redundant here, no point testing runtime behaviour
There was a problem hiding this comment.
not entirely, it's still worth checking that the generated property actually has the value we expect it to have. Could catch a potential bugs like types not being recognized or accessors mismatching the correct columns
| return SimpleFrameColumn( | ||
| name, | ||
| f(columns(), nextName, selected, path) | ||
| internal fun SimpleFrameColumn.map( |
There was a problem hiding this comment.
Please, for easy and fast reviews let's hold changes related to linting and other non-functional changes
There was a problem hiding this comment.
I put it in a separate commit, so you can skip those if you wish
Jolanrensen
force-pushed
the
rename-to-camelcase-2
branch
from
88599a7 to
cd5888c
Compare
Fixes #1025
Adds compiler plugin support for
DataFrame.renameToCamelCase()andDataFrame.rename {}.toCamelCase()Got some help from Junie :) The first function was almost entirely written by AI, the second one needed a more guiding hand from me.
See commit messages for more specifics