feat(crd): add KongTarget CRD #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
reviewed
Sep 12, 2024
There was a problem hiding this comment.
How about adding a bunch of UTs like in https://github.com/Kong/kubernetes-configuration/blob/960b674e12d69aa0ca2dd6be26c840bdf5a31768/test/unit/kongupstream_test.go and CRD validation tests in https://github.com/Kong/kubernetes-configuration/tree/main/test/crdsvalidation ?
randmonkey
force-pushed
the
feat/kongtarget
branch
from
6061a41 to
4e214eb
Compare
Added unit tests. |
pmalek
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add
KongTargetCRD for Konnect entities. Also fixed some copy-pasta mistakes.Which issue this PR fixes
Required for Kong/gateway-operator#576.
Special notes for your reviewer:
Since targets are always attached to an upstream, here
upstreamRefis required. Should we define it as required (for possibility that aKongTargetis attached to another upstream that is not generated fromKongUpstream?)PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes