fix: make KongRoute CEL validations work as expected #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
test/kongroute
branch
3 times, most recently
from
eace70e to
c1cf995
Compare
czeslavo
force-pushed
the
test/kongroute
branch
2 times, most recently
from
3c61993 to
9769893
Compare
czeslavo
force-pushed
the
test/kongroute
branch
from
9769893 to
277cee0
Compare
czeslavo
changed the title
programmer04
reviewed
Sep 5, 2024
czeslavo
force-pushed
the
test/kongroute
branch
from
3b60622 to
4aedbe3
Compare
programmer04
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds missing
KongRouteCEL rules and fixes the existing one forprotocolsthat was failing when noprotocolsis provided (which should be correct).