feat(tendermint): unstaking/undelegation #2330
Open
+352
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
onur-ozkan
changed the title
onur-ozkan
commented
Jan 30, 2025
Comment on lines
+751
to
+755
| let tx_details = block_on(tendermint_remove_delegation(&mm, coin_ticker, VALIDATOR_ADDRESS, "0.5")); | ||
|
|
||
| assert_eq!(tx_details.from, vec![MY_ADDRESS.to_owned()]); | ||
| assert!(tx_details.to.is_empty()); | ||
| assert_eq!(tx_details.transaction_type, TransactionType::RemoveDelegation); |
There was a problem hiding this comment.
TODO: add coverage for "undelegating more than the delegated amount".
onur-ozkan
commented
Jan 30, 2025
Comment on lines
+715
to
+716
| #[test] | ||
| fn test_tendermint_remove_delegation() { |
There was a problem hiding this comment.
Self note: may need to lock these tests to avoid account sequence number race conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tendermint protocol support on
remove_delegationRPC, and extends tendermint transaction history implementation to support undelegate transactions.Next is to add staking listing RPCs for delegations, undelegations (with claiming period informations), rewards, etc.