Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Niko switch action reporting functionality #8635

Merged
merged 7 commits into from
Jan 27, 2025
Merged

Add Niko switch action reporting functionality #8635

merged 7 commits into from
Jan 27, 2025
+197 −55

Conversation

svenjochems
Copy link
Contributor

@svenjochems svenjochems commented Jan 18, 2025 •
edited
Loading

Some Niko switches are not reporting state updates as 'action' values.
Based on research in Koenkk/zigbee2mqtt#13737 and zigpy/zha-device-handlers#3701.

Changes:

  • Add switchActionReporting attribute to enable or disable the reporting of action values
  • Move custom Niko Clusters manuSpecificNiko1 and manuSpecificNiko2 from zigbee-herdsman to modernExtend manuSpecificNikoConfig and manuSpecificNikoState
  • Change ledState property from ON/OFF to ON/OFF/Blue/Red/Purple
  • Add ledSyncMode option
  • Change action implementation to support pushing multiple buttons together
  • action null values are not published anymore

@svenjochems svenjochems mentioned this pull request Jan 18, 2025
Closed
Koenkk
Koenkk reviewed Jan 19, 2025
View reviewed changes
src/devices/niko.ts Outdated Show resolved Hide resolved
svenjochems
svenjochems commented Jan 20, 2025
View reviewed changes
src/devices/niko.ts Outdated Show resolved Hide resolved
@svenjochems svenjochems mentioned this pull request Jan 20, 2025
Merged
svenjochems
svenjochems commented Jan 24, 2025
View reviewed changes
src/devices/niko.ts Outdated Show resolved Hide resolved
svenjochems
svenjochems commented Jan 24, 2025
View reviewed changes
src/devices/niko.ts Outdated Show resolved Hide resolved
@svenjochems
Copy link
Contributor Author

@Koenkk @sjorge I have finished my changes. This PR is ready for review

@Koenkk Koenkk merged commit 4ae589e into Koenkk:master Jan 27, 2025
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Jan 27, 2025

Looks good, thanks!

@Koenkk Koenkk mentioned this pull request Jan 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Koenkk Koenkk Koenkk left review comments

@sjorge sjorge sjorge left review comments

@Magkoooh Magkoooh Magkoooh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@svenjochems @Koenkk @sjorge @Magkoooh