Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite Directory deployed on each commit #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

costrouc
Copy link
Contributor

This is a WIP. Will add travis ci for build and sqlite database potentially will be stored in github pages? Not sure maybe deployed somewhere with datasette.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Data Submissions:

  1. Does your submission pass tests?
    • valid yaml
    • follows template for the data type submitting.
  2. Have you lint your code locally prior to submission?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@costrouc
Copy link
Contributor Author

costrouc commented Aug 1, 2019

@alexpawlowski what are your thoughts of this current code? This is a bare minimum working version and it would be nice to know additional thing that would be nice to have. The only dependncy of pyyaml ... which is necessary in this case.

General process. Take all metadata files of a given category (for example "organizers") and flatten the namespaces. Then with the flattened namespaces generate a sqlite table schema and insert each file. Currently tags in groups and group in organizers are skipped becuase lists require a many to many relationship table to be formed (certainly something that could be added).

Future work (could be in this PR).

Happy to hear your input!

@costrouc costrouc changed the title [WIP] SQLite Directory deployed on each commit SQLite Directory deployed on each commit Aug 1, 2019
@alexpawlowski
Copy link
Member

@costrouc can you add a sample sqlite file? I'd like to see if it meets the format of what @wigging was thinking.

@alexpawlowski
Copy link
Member

To make this process simpler @costrouc I have removed tags from the yml files in my latest commit 0b9ebfb. Only @wigging and I were using those, and that information could be pulled from the description of each meetup, or we could add that functionality back (currently not using). In addition spaces have been consolidated.

@alexpawlowski
Copy link
Member

Additionally, I have forced the yml files to be consistent, showing entries within each yml file as blank if there isn't a value. (Before if it was blank, the field often wasn't found in the yml file)

@wigging
Copy link
Contributor

wigging commented Aug 3, 2019

This is the SQLite database file (knoxdevs.db) I created for the iOS app.
https://github.com/knoxcocoa/knoxdevs/tree/master/knoxdevs/Database

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants