Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy to production #599

Merged
merged 16 commits into from
May 29, 2024
Merged

Deploy to production #599

merged 16 commits into from
May 29, 2024

Conversation

Greenheart
Copy link
Collaborator

@Greenheart Greenheart commented May 27, 2024

Included changes

  • Show map view first for municipalities - Larry
  • Remove duplicated words in company data - Larry
  • Remove unused Borna font assets - Narges
  • Improved table UX, scrolling the full page, sticky table header and table footer. Improved layout on smaller screen sizes - Samuel
  • Updated tests for SMHI data - Mathias
  • Removed old data output files and move consumption data to Excel - Elvira
  • Feature: Make Python tests for SMHI data independent from the last year with data - Elvira
  • Added Instagram logo and link to footer - Oskar
  • Improve map legend to clearly show the map legend on top of - SimonAM
  • Add GitHub templates for new issues - Ludvig

mathiasb and others added 8 commits May 20, 2024 08:15
… SMHI data (#586)

* update last year w smhi data and cement deduction values for 2022

* update smhi test files

* make tests work regardless of last year with smhi data

* change from year 2022 to 2021 (to be introduced in later pr)

* add 2022 to smhi test
* Allow closing the main menu by pressing the Escape key

* Replace devices.mobile (which used max-width) with other breakpoints.

This makes sure all breakpoints are consistent and all media queries should be written with a mobile-first approach.

* Ensure hamburger menu has consistent size and positioning for all screen sizes

* Change breakpoint size to standard value, since it was only used in one place

* Ensure consistent height for the Header. Also improve vertical alignment for logo. Also make desktop navigation appear already for smaller laptop screens, to make give a better UX.

* Improve spacing for the RegionalView

* WIP: Make the CompanyView use the page scroll

* Fix CompanyView table header positioning

* Use full page scroll for RegionalView table

* Update copy to match new version

* Alternative 1 for CompanyView table

* Alternative 2 for CompanyView table

* Add sticky footer for RegionalView too

* Fix map height for RegionalView

* Remove unused calc()

* Attempt to simplify CSS calculations to hopefully fix iOS positioning problems

* Simplify copy to save space

* WIP: experiment with IntersectionObserver to work around position sticky not working for `thead` elements in Safari

* Override tough-cookie dependency to remove Node.js deprecation warning in Node >= 21

* Mock IntersectionObserver to fix tests for CompanyView and RegionalView

* Try if inset-block-start works better for sticky thead

* FINALLY! Fixex position sticky in Safari 17. This already worked in older versions of Safari and all other browsers, but for some reason Safari 17 seems to have a buggy implementation.

* Cleanup WIP code and comments

* Cleanup tests and import

* Add webkit prefix for increased backwards compatibility
* removed the unneeded Borna font assets(#463)

* Keep Borna font files used for the site, and remove other files

* Remove unintended changes

---------

Co-authored-by: Narges <[email protected]>
Co-authored-by: Samuel Plumppu <[email protected]>
* fix words written twice

* Update source data file too

---------

Co-authored-by: Samuel Plumppu <[email protected]>
Copy link

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
klimatkollen ✅ Ready (Inspect) Visit Preview May 29, 2024 0:11am

* Social links update

Added links with corresponding icons to Klimatkollen's profile on Facebook and Instagram.

* Discord logo

 Fixed dimensions

* Update FooterSocialLinks.tsx

* Added only Instagram icon and link
@elvbom
Copy link
Collaborator

elvbom commented May 27, 2024

Also added Instagram logo and link to footer

Add an issue template for better issues.
@Greenheart Greenheart marked this pull request as ready for review May 28, 2024 13:31
@Greenheart
Copy link
Collaborator Author

As soon as #602 is merged, we can test and deploy this.

* experiment with map labels

* feat: floating titlecontainer with background

* fix: hide map pegend when in list view

* chore: formatting

* Update styles

* Allow scrolling even when the MapLabels are on top to improve navigation on mobile

This sometimes makes the map labels show beneath, but overall this is an UX improvement for mobile users which makes it worth it.

---------

Co-authored-by: Samuel Plumppu <[email protected]>
Copy link
Collaborator

@elvbom elvbom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table footer font size is rather small on desktop, can it be made larger?

Screenshot 2024-05-29 at 10 51 20

@Greenheart Greenheart merged commit 985046b into main May 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants