-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release to production #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Types need to be fixed.
* updated company data * rm leading and trailing spaces * Fix formatting for emission scopes that are not reported --------- Co-authored-by: Samuel Plumppu <[email protected]>
* Fix React warning and document upcoming tasks * WIP: expandable rows * Make every row expandable by default * Fix syntax error * Clarify styling for expanded rows * Show company name in collapsed view * Improve styling for expanded rows * Adapt for tablet * Remove old code * Prevent column widths from changing when expanding rows * Remove trim * Use translated string
…to reduce client side JS and rely on server state + link prefetching instead.
… datasets. Remove response caching since that duplicates data and uses more RAM.
Feat/garbo mvp company list view
* Add missing key prop * Remove copy from CompanyView to match latest suggestion * Update table headers and add some strings to translations * Improve table header font size for small screen sizes * Improve size and spacing for table * Use full-width table for all mobile sizes. * Fix offset for sticky table header. Also hide background content above it. * Improve compact layout for tables on smaller screens * Improve table layout for small screens. * More compact table header to save screen height on mobile * Cover full width with table for all mobile devices * Fix margin positioning for ToggleButton * Update table footer copy * Reference arrow svg as img instead of inlined SVG. This improves rendering performance. * Update newsletter info * Update about us text * Move text about previous project * Update sources and method * Use plural key to prepare for i18n * Fix tests for StartPage by splitting into two modules: CompanyView and RegionalView * Cleanup tests * Add privacy policy as separate page * Add description of the method for company data
* Allow closing the main menu by pressing the Escape key * Replace devices.mobile (which used max-width) with other breakpoints. This makes sure all breakpoints are consistent and all media queries should be written with a mobile-first approach. * Ensure hamburger menu has consistent size and positioning for all screen sizes * Change breakpoint size to standard value, since it was only used in one place * Ensure consistent height for the Header. Also improve vertical alignment for logo. Also make desktop navigation appear already for smaller laptop screens, to make give a better UX.
… of forcing ASCII (#564) * Reduce size of company-data.json by 9% by encoding as UTF-8 instead of forcing ASCII. This aligns with how we output climate-data.json. * Update to latest company data
…566) * Improve styles for the newsletter form * Allow overriding color of arrow icon * Update copy for CompanyView table footer info * Add smaller text for PrivacyInfo paragraph
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
elvbom
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done everyone!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release includes these changes:
company-data.json
by 9% by encoding as UTF-8 instead of forcing ASCII #564