Various fixes #29
Merged
Various fixes #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add partial KHR_node_visibility full support requires a later BabylonJS version with inheritVisibility
…es, but id is purely informative
|
yes, I plan to fix up the json naming semantics once they are completely set in the spec (they have changed a lot and often) |
|
Yeah agree. I changed the ones on-the-fly that I noted were different from the spec, as we make our way through the UnityGLTF implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially closes #27
I think it would be good to do a pass over the "values" vs. "val" thing, and "done" vs. "complete", to ensure that the current spec proposal is matched – this PR only does that for a few nodes.