-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] schema: refactoring to improve checking #172
Conversation
CI VulkanProfiles build # 1671 running. |
CI VulkanProfiles build # 1671 failed. |
Schema Implementation:
JSON file example (if
|
We could implement exclusion of extension vs core version like this:
JSON files (if VK_VERSION_1_1 is defined, we get errors):
This said, a device profiles will have both the core and the extension defined so we should somehow make this a mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. If I see this correctly this would also fix the problem where we had structs from extensions used, but the extension itself was not listed, correct?
Yes, and ensure the extension dependencies are resolved. |
Similarly we could prevent a profile file to specify both the bundle and the core structure with |
Moved to future version 2.0 issue: #310 |
Done:
TODO: