EGL_ANDROID_native_fence_sync: Fix the attribute that must be set after a flush #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er a flush The EGL_SYNC_NATIVE_FENCE_FD_ANDROID attribute of an EGL sync object is intended to be set to a file descriptor that refers to the underlying native fence object. However, a sentence in the specification suggests that the EGL_SYNC_NATIVE_FENCE_ANDROID attribute is used for storing file descriptors instead. This is probably a typo since EGL_SYNC_NATIVE_FENCE_ANDROID is not an attribute.
dkorkmazturk
force-pushed
the
native_fence_sync
branch
from
513916a to
4914f22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EGL_SYNC_NATIVE_FENCE_FD_ANDROID attribute of an EGL sync object is intended to be set to a file descriptor that refers to the underlying native fence object.
However, a sentence in the specification suggests that the EGL_SYNC_NATIVE_FENCE_ANDROID attribute is used for storing file descriptors instead. This is probably a typo since EGL_SYNC_NATIVE_FENCE_ANDROID is not an attribute.