Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hdanari misc fixes #263

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Conversation

tarcila
Copy link
Contributor

@tarcila tarcila commented Nov 18, 2024

This PR brings the following to hdanari:

  • Clang formatting, that should have been there from previous PRs...
  • Some CMake changes that hides all symbols by defaults and provides some api.h to help controlling the visibility of the symbols. Note that NO symbols are exported for now, as the registration mechanism of USD makes it so that no symbols are actively queried by USD plugin mechanism...
  • Some fixes where:
    • Hdanari was not building on Windows
    • Some images were not loaded correctly
    • Instancing was broken with animation/updates when not using array instancing.

Handle sRGB at resource creation time instead of loading time.
Hio expects the actual image format, not a possible target one.
Some information were not recomputed if not dirty, but lost after the initial frane.
Keep those information cached.
@jeffamstutz jeffamstutz merged commit 98ca1f5 into KhronosGroup:next_release Nov 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants