[axes-aria-descriptions] [SR] Add aria-labels for x- and y-axis labels #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now if a person using a screen reader traverses through the graph, they hear "x, math" and "y, math" for the axis labels, or whatever the x and y labels are updated to by the content authors. We need to add a description for this so people know what x and y are referring to. - Added "X-axis" and "Y-axis" strings as `aria-label`s for the `AxisLabel` elements. - This means that it reads the actual label as a child of this axis label group - This is my preferred approach so that it already handles math speech wehen reading the TeX label, and we don't have to manually use the speech rule engine again redundantly Issue: https://khanacademy.atlassian.net/browse/LEMS-2844 Test plan: `yarn jest packages/perseus/src/widgets/interactive-graphs/mafs-graph.test.tsx` Storybook - Go to any interactive graph editor story (http://localhost:6006/iframe.html?globals=&args=&id=perseuseditor-widgets-interactive-graph--interactive-graph-segment&viewMode=story) - Use the screen reader to confirm that the axis labels now say "X-axis, group" - Continue using the screen reader and make sure that the actual axis label is read - Update the x and y labels to have some kind of math TeX like `\frac{1}{2}` - Repeat the above steps and confirm that the screen reader reads the math correctly
… and y-axis labels
nishasy
commented
Feb 8, 2025
| @@ -17,6 +17,8 @@ import type {InteractiveGraphState} from "./types"; | |||
| import type {GraphRange} from "@khanacademy/perseus-core"; | |||
| import type {UserEvent} from "@testing-library/user-event"; | |||
|
|
|||
| const baseMafsProps = getBaseMafsGraphPropsForTests(); | |||
There was a problem hiding this comment.
While I was in this file, I took this as an opportunity to reduce the number of function calls being made.
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (7e7e469) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2221If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2221 |
|
Size Change: +61 B (0%) Total Size: 1.48 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Right now if a person using a screen reader traverses through the graph, they hear "x, math" and "y, math" for the axis labels, or whatever the x and y labels are updated to by the content authors.
We need to add a description for this so people know what x and y are referring to.
aria-labels for theAxisLabelelements.TeX label, and we don't have to manually use the speech rule engine again redundantly
Issue: https://khanacademy.atlassian.net/browse/LEMS-2844
Test plan:
yarn jest packages/perseus/src/widgets/interactive-graphs/mafs-graph.test.tsxStorybook
\frac{1}{2}