-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TECH: added bluetooth's switcher #684
base: master
Are you sure you want to change the base?
Conversation
1a7310f
to
32eb9e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changeBluetoothStateUsingAdbServer method needs attention. Everything else either minor or LGTM
logger.i("Bluetooth is not supported") | ||
return | ||
} | ||
logger.i("${if (enable) "En" else "Dis"}able bluetooth") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, make two separate calls to the logger. Concatenating log strings make them almost imposible to find in the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
kaspresso/src/main/kotlin/com/kaspersky/kaspresso/device/bluetooth/BluetoothImpl.kt
Show resolved
Hide resolved
kaspresso/src/main/kotlin/com/kaspersky/kaspresso/device/bluetooth/BluetoothImpl.kt
Show resolved
Hide resolved
Hi! why you don't use more stable way to turn on/off bluetooth
For disabling you can use same adb command "adb shell am start - a android.bluetooth.adapter.action.REQUEST_DISABLE" |
/** | ||
* The implementation of the [Bluetooth] interface. | ||
*/ | ||
class BluetoothImpl( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this class is only needed inside our framework and should not be visible outside - let's make it internal to limit the creation of new instances and minimize the side effects of possible breaking changes in this class
No description provided.