Extend hanami_context_logging to handle non-hash ContextProvider#context #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not a hash, but responds to #to_h This is so that we can be compatible with Oculus 0.2.1, which changes the Context from a hash to be an object (with more capabilities)
hieuk09
reviewed
Oct 25, 2024
Comment on lines
+20
to
+23
| provider_context = if @context_provider.context.is_a?(Hash) | ||
| @context_provider.context | ||
| else | ||
| @context_provider.context.to_h |
There was a problem hiding this comment.
Maybe we can always call to_h since Hash#to_h returns itself
There was a problem hiding this comment.
that's what @tsungtingdu and I also mentioned, but I thought this is more intentional :keke:
tsungtingdu
approved these changes
Oct 28, 2024
|
@sswander it works
fyi, I still need to add |
That is true... this is on Oculus side then. Thanks Tim 🙏 Meanwhile I'll bump the version and merge this PR |
|
@tsungtingdu you should be able to use this tag now like this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But this at least it has to be convertible to hash via
#to_hThis is so that we can be compatible with Oculus 0.2.1, which changed the Context from actual ruby hash to be an object (with more capabilities) -- see https://github.com/Kaligo/oculus/pull/3/files#diff-3eb728766f4a509971570cab11b09e56c1ae9c480dad013ecd314fa80ba321d6L10