Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CheckResult to KRecycler's childWith #134

Merged
merged 4 commits into from
Oct 19, 2024
Merged

Conversation

Mexator
Copy link
Contributor

@Mexator Mexator commented Oct 10, 2024

My team quite often make mistakes using childWith. They write something like:

myKRecycler.childWith<HeaderKItem> {
    doesNotExist()
}

I added a lint rule to our project and now I wan't to discuss, maybe it worth adding CheckResult (or analogous annotation) here? This way default Android Lint rules may be used to detect such issues

@Vacxe
Copy link
Member

Vacxe commented Oct 19, 2024

@Mexator can't see any reasons to avoid this. Thanks for the contribution.

@Vacxe Vacxe changed the base branch from master to develop October 19, 2024 13:43
@Vacxe Vacxe merged commit e9378b7 into KakaoCup:develop Oct 19, 2024
3 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants