Adding the functionality to include analysis specific c++ code to CROWN #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-monsch
requested review from
nfaltermann,
winterchristian,
nshadskiy and
tvoigtlaender
a-monsch
assigned a-monsch, nfaltermann, winterchristian, nshadskiy and tvoigtlaender and unassigned nfaltermann, winterchristian, nshadskiy and tvoigtlaender
nshadskiy
reviewed
Dec 11, 2024
There was a problem hiding this comment.
The included directories should be as restricted as possible.
Also, the downstream effects of this change should be considered.
To me, it looks like KingMaker is not affected by this change.
It should be tested anyway to make sure nothing breaks. Especially because KingMaker currently only clones the newest version of CROWN during setup, not a specific commit.
|
Added PR to this branch and KingMaker main branch. |
…figurations_fix Fix for cpp_addons PR. Templating for subset_template fixed.
nshadskiy
reviewed
Jan 15, 2025
nshadskiy
approved these changes
Jan 15, 2025
|
The issue with the authentication is resolved for now. To get the jsonpog repository we need a valid private ssh key to access CERN gitlab. The previous one was probably Sebastians, so I guess it expired. I now added my ssh key. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of functionality to offload c++ specific code to analysis specific configurations stored in
cpp_addons/includeandcpp_addons/srcThings that need to be done: