Refactor wait(::Session) so that the polling happens asynchronously #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17 +/- ##
==========================================
+ Coverage 59.52% 60.43% +0.91%
==========================================
Files 11 11
Lines 2777 2836 +59
==========================================
+ Hits 1653 1714 +61
+ Misses 1124 1122 -2 ☔ View full report in Codecov by Sentry. |
Previously each call to `wait(::Session)` would poll the sessions file descriptor individually. This is kinda not great because one caller may be woken up for some data that's intended for another caller. In practice this hasn't caused problems so far because most of LibSSH's usage has been in the tests where we do a single operation at a time, but the new architecture should be safer. Now there's a separate waiter task that lives for as long as the session that can be woken up by callers wanting to wait() on the session, who will in turn be woken up whenever the waiter tasks polls the session file descriptor successfully. i.e. it turns the waiting from a 1-to-1 thing to a 1-to-many thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously each call to
wait(::Session)would poll the sessions file descriptor individually. This is kinda not great because one caller may be woken up for some data that's intended for another caller. In practice this hasn't caused problems so far because most of LibSSH's usage has been in the tests where we do a single operation at a time, but the new architecture should be safer.Now there's a separate waiter task that lives for as long as the session that can be woken up by callers wanting to wait() on the session, who will in turn be woken up whenever the waiter tasks polls the session file descriptor successfully. i.e. it turns the waiting from a 1-to-1 thing to a 1-to-many thing.