Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Real to Number #79

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

geoffroyleconte
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 88.91% // Head: 88.91% // No change to project coverage 👍

Coverage data is based on head (2d747e8) compared to base (51eec8d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   88.91%   88.91%           
=======================================
  Files           1        1           
  Lines         388      388           
=======================================
  Hits          345      345           
  Misses         43       43           
Impacted Files Coverage Δ
src/LimitedLDLFactorizations.jl 88.91% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dpo
Copy link
Member

dpo commented Mar 9, 2023

Could we just leave Tf as an (unspecified) parameter?

@geoffroyleconte
Copy link
Member Author

Probably, the only issue would be that if there is an error because of Tf, it would be more difficult to debug (for example I don't know if this would work directly for complex numbers).
If you think that it's fine, I can open a PR.

@dpo
Copy link
Member

dpo commented Mar 10, 2023

As you pointed out earlier, we need to use conj in appropriate places to ensure correctness, but I think I would leave Tf free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants