-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide issue/PR list on backports #206
Conversation
Automated changelogs for backports tend to be wildly incorrect. | ||
Therefore, the list of issues and pull requests is hidden. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this is the best wording.
The ideal wording would have the following effects:
- a normal user would be aware that this is a back-port, and not be too distracted by the stuff intended for maintainers
- a maintainer would realize that they should edit this.
Possibly the maintainer would realize there is something filled in, before they click edit, but not necessarily, since it would be obvious once they go to edit?
81e26f8
to
b7ed67e
Compare
@christopher-dG @oxinabox Is this PR ready to merge? |
Bump @christopher-dG |
b7ed67e
to
9b58973
Compare
6e30f45
to
e8e64d4
Compare
e8e64d4
to
efb6019
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If there's room for improvement in the language it can be a follow on
@oxinabox had a great idea here: #181 (comment)