Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide issue/PR list on backports #206

Merged
merged 7 commits into from
Aug 22, 2024
Merged

Hide issue/PR list on backports #206

merged 7 commits into from
Aug 22, 2024

Conversation

christopher-dG
Copy link
Member

@oxinabox had a great idea here: #181 (comment)

Comment on lines +78 to +89
Automated changelogs for backports tend to be wildly incorrect.
Therefore, the list of issues and pull requests is hidden.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this is the best wording.
The ideal wording would have the following effects:

  • a normal user would be aware that this is a back-port, and not be too distracted by the stuff intended for maintainers
  • a maintainer would realize that they should edit this.

Possibly the maintainer would realize there is something filled in, before they click edit, but not necessarily, since it would be obvious once they go to edit?

@DilumAluthge
Copy link
Member

@christopher-dG @oxinabox Is this PR ready to merge?

@DilumAluthge
Copy link
Member

Bump @christopher-dG

Copy link
Member

@IanButterworth IanButterworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If there's room for improvement in the language it can be a follow on

@IanButterworth IanButterworth merged commit 7d86458 into master Aug 22, 2024
3 checks passed
@IanButterworth IanButterworth deleted the cdg/backport branch August 22, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants