Skip to content

Commit

Permalink
Merge pull request #215 from JuliaRegistries/dpa/patch-Julia-compat
Browse files Browse the repository at this point in the history
Drop the "can’t narrow Julia compat in a patch release" requirement for pre-1.0 packages
  • Loading branch information
DilumAluthge authored Feb 21, 2020
2 parents 40d40f8 + 8ea51f6 commit 86f26d8
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 9 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "RegistryCI"
uuid = "0c95cc5f-2f7e-43fe-82dd-79dbcba86b32"
authors = ["Dilum Aluthge <[email protected]>", "Fredrik Ekre <[email protected]>"]
version = "0.11.8"
version = "0.12.0"

[deps]
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
Expand Down
21 changes: 13 additions & 8 deletions src/AutoMerge/guidelines.jl
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,19 @@ function meets_patch_release_does_not_narrow_julia_compat(pkg::String,
if meets_this_guideline
return true, ""
else
msg = string("A patch release is not allowed to narrow the ",
"supported ranges of Julia versions. ",
"The ranges have changed from ",
"$(julia_compats_for_old_version) ",
"(in $(old_version)) ",
"to $(julia_compats_for_new_version) ",
"(in $(new_version)).")
return false, msg
if (old_version >= v"1") || (new_version >= v"1")
msg = string("A patch release is not allowed to narrow the ",
"supported ranges of Julia versions. ",
"The ranges have changed from ",
"$(julia_compats_for_old_version) ",
"(in $(old_version)) ",
"to $(julia_compats_for_new_version) ",
"(in $(new_version)).")
return false, msg
else
@info("Narrows Julia compat, but it's OK since package is pre-1.0")
return true, ""
end
end
end

Expand Down

3 comments on commit 86f26d8

@DilumAluthge
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register branch=master

@DilumAluthge
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register branch=master

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/9847

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if Julia TagBot is installed, or can be done manually through the github interface, or via:

git tag -a v0.12.0 -m "<description of version>" 86f26d8273db4cecc9a4af435e8c95e33cb1a468
git push origin v0.12.0

Please sign in to comment.