-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: ROOT v0.3.0 #108095
New package: ROOT v0.3.0 #108095
Conversation
JuliaRegistrator
commented
Jun 2, 2024
•
edited
Loading
edited
- Registering package: ROOT
- Repository: https://github.com/JuliaHEP/ROOT.jl
- Created by: @grasph
- Version: v0.3.0
- Commit: 8094ac289cc962c3fe1240c70f2100acef935bdc
- Reviewed by: @grasph
- Reference: Registration in the general registry JuliaHEP/ROOT.jl#22 (comment)
- Description: CERN ROOT compatiblility for Julia
cd14f42
to
0102f96
Compare
Your
Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text |
Does this really need |
(Let me hold off on the "needs to be merged manually in 3 days" tag, since at least the compat-issues need to be fixed before it's ready to merge) |
The library it wraps is installed with Conda. Ultimately the BinaryProvider will be used, but the cross-compilation is a challenge for the ROOT library source, which is not yet solved yet (JuliaPackaging/Yggdrasil#7666). Use of Conda was a compromise in order to move on with the distribution of this wrapper. For the compat specs what is the recommendations? Should I used major.minor of the latest version? |
0102f96
to
1c19e63
Compare
That's what I usually do. Or, hypothetically, you could try to find out what are the oldest versions that actually work (make sure to have an entry in your test matrix that installs your dependencies in their declared oldest versions, to make sure it actually works and to tell you when you need to bump the compat entries). |
UUID: 1706fdcc-8426-44f1-a283-5be479e9517c Repo: https://github.com/JuliaHEP/ROOT.jl.git Tree: b9a6a9d56763bfc909a072539477666905fa10ae Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
1c19e63
to
80b2515
Compare
Can we proceed with the merging of this PR? Let me know if I can do anything on my side. I don't understand the logs of AutoMerge: all the messages before the exception say "meets_this_guideline = true", but may be it is due to the package name, which requires a manual merge as discussed earlier. Thanks, |
You’re okay, the only thing to do is to periodically ping the |
Thanks @goerz for this information. I've posted a message on the Slack channel. |
Thanks @ericphanson for the merge. |