Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: ROOT v0.3.0 #108095

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Jun 2, 2024

Copy link
Contributor

github-actions bot commented Jun 2, 2024

Your new package pull request does not meet the guidelines for auto-merging. Please make sure that you have read the General registry README and the AutoMerge guidelines. The following guidelines were not met:

  • Name does not meet all of the following: starts with an upper-case letter, ASCII alphanumerics only, not all letters are upper-case.
  • Name is not at least 5 characters long

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number).

If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the #pkg-registration channel in the Julia Slack to ask for help. Include a link to this pull request.

Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

@goerz
Copy link
Member

goerz commented Jun 2, 2024

Does this really need conda as a dependency?

@goerz
Copy link
Member

goerz commented Jun 2, 2024

(Let me hold off on the "needs to be merged manually in 3 days" tag, since at least the compat-issues need to be fixed before it's ready to merge)

@grasph
Copy link

grasph commented Jun 2, 2024

The library it wraps is installed with Conda. Ultimately the BinaryProvider will be used, but the cross-compilation is a challenge for the ROOT library source, which is not yet solved yet (JuliaPackaging/Yggdrasil#7666). Use of Conda was a compromise in order to move on with the distribution of this wrapper.

For the compat specs what is the recommendations? Should I used major.minor of the latest version?

@JuliaRegistrator JuliaRegistrator force-pushed the registrator-root-1706fdcc-v0.3.0-639df1e57f branch from 0102f96 to 1c19e63 Compare June 2, 2024 17:34
@goerz
Copy link
Member

goerz commented Jun 2, 2024

Should I used major.minor of the latest version?

That's what I usually do. Or, hypothetically, you could try to find out what are the oldest versions that actually work (make sure to have an entry in your test matrix that installs your dependencies in their declared oldest versions, to make sure it actually works and to tell you when you need to bump the compat entries).

UUID: 1706fdcc-8426-44f1-a283-5be479e9517c
Repo: https://github.com/JuliaHEP/ROOT.jl.git
Tree: b9a6a9d56763bfc909a072539477666905fa10ae

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
@JuliaRegistrator JuliaRegistrator force-pushed the registrator-root-1706fdcc-v0.3.0-639df1e57f branch from 1c19e63 to 80b2515 Compare June 6, 2024 22:00
@grasph
Copy link

grasph commented Jun 9, 2024

Can we proceed with the merging of this PR?

Let me know if I can do anything on my side. I don't understand the logs of AutoMerge: all the messages before the exception say "meets_this_guideline = true", but may be it is due to the package name, which requires a manual merge as discussed earlier.

Thanks,
Philippe.

@goerz
Copy link
Member

goerz commented Jun 9, 2024

You’re okay, the only thing to do is to periodically ping the #pkg-registration channel on Slack. Usually things get merged quickly, but there’s been a backlog the past week. There’s a pretty small group of full maintainers who have merge permission, and maybe they’re all traveling/busy/on holiday, or something

@grasph
Copy link

grasph commented Jun 9, 2024

Thanks @goerz for this information. I've posted a message on the Slack channel.

@ericphanson ericphanson merged commit 84e5f51 into master Jun 9, 2024
9 of 11 checks passed
@ericphanson ericphanson deleted the registrator-root-1706fdcc-v0.3.0-639df1e57f branch June 9, 2024 20:23
@grasph
Copy link

grasph commented Jun 12, 2024

Thanks @ericphanson for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants