Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend that most users use the new compathelper-action composite action #379

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DilumAluthge
Copy link
Member

This PR changes the officially recommended workflow file to use the new compathelper-action composite action: https://github.com/JuliaRegistries/compathelper-action

This PR should not be merged until we first tag a release of the compathelper-action action.

@SaschaMann
Copy link
Contributor

Perhaps also add a GHA-warning to CompatHelper.jl so that people notice that they could/should switch more easily?

@DilumAluthge
Copy link
Member Author

Perhaps also add a GHA-warning to CompatHelper.jl so that people notice that they could/should switch more easily?

We could, but:

  1. How can we tell if someone's using the new composite action versus the old workflow file? Presumably there's no point in printing a warning if they've already switched to the composite action?
  2. Do people actually look at the CompatHelper logs? My impression is that most people don't look at the logs, especially if the CompatHelper job isn't failing.

@SaschaMann
Copy link
Contributor

Do people actually look at the CompatHelper logs? My impression is that most people don't look at the logs, especially if the CompatHelper job isn't failing.

Right, that's probably true. 1) could be done by searching the workflow dir but I didn't consider that people don't really look at these.

@DilumAluthge DilumAluthge changed the title Recommend that most users use the new compathelper-action Recommend that most users use the new compathelper-action composite action Aug 28, 2021
bors bot added a commit that referenced this pull request Aug 28, 2021
@JuliaRegistries JuliaRegistries deleted a comment from bors bot Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants