Added user site bin for julia-py #312
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 792
💛 - Coveralls |
tkf
requested changes
Jul 31, 2019
src/julia/tools.py
Outdated
| stempath = os.path.join(os.path.dirname(executable), "julia-py") | ||
| candidates = {os.path.basename(p): p for p in glob.glob(stempath + "*")} | ||
| basedirs = {os.path.dirname(executable), | ||
| os.path.join(site.USER_BASE, "bin")} |
There was a problem hiding this comment.
Why use set? I think we should use a list here in the order of increasing preference (so that the values of candidates are the one in the most preferred location). Does basedirs = [os.path.dirname(executable), os.path.join(site.USER_BASE, "bin")] + site.PREFIXES make sense?
There was a problem hiding this comment.
Actually, os.path.join(site.USER_BASE, "bin") may not work in Windows? Is there a pre-defined path we can use?
There was a problem hiding this comment.
Thanks for the hint! I've changed the logics according to your remarks. On Windows there seem to be more difficulties anyway (starting with "libjulia" library extension), but this part looks like it should work if the rest does too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I'm using
setup.py develop --userin my setup,julia-pybinary is installed in~/.local/bin. Rather than hardcoding the path to be at the same place as thepythonbinary, one should look also there. This patch adds this behavior. Do you think one could also usesite.PREFIXESto replace the default binary path? In that case I will create another patch.