-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add satified_skip_solve as a keyword argument for Conda.add #241
Conversation
LGTM The CI is broken FYI, so just merge |
Yes, but why? |
Broken since November: https://github.com/JuliaPy/Conda.jl/commits/master |
Yes, but why is CI so broken. |
@stevengj any idea? |
What is happening on Windows? AttributeError: module 'brotli' has no attribute 'error' |
LGTM. The CI problem on Windows is not a regression so it shouldn't be blocking. |
This seems to breaks CI on x86 ubuntu workflows, see here. Could this be reverted for now? Also, the CI here seems unfortunately limited, shouldn't it run on more Julia versions and on things like x86? |
I guess that is because there is no miniforge for x86: |
Is there commercial miniconda for x86? https://docs.conda.io/en/latest/miniconda.html |
There seems to be something, right? It does look like some kind of |
My guess is that we are pulling in a very old version of conda when x86 was supported. I will investigate further before trying to sort out the fix. |
@davidanthoff My proposed fix is JuliaPy/PyCall.jl#1045 |
Add --satisified-skip-solve as an argument for Conda.add.
This will allow PyCall.jl to ensure that numpy is installed, but not update it if it already in the environment.