fix error in change_plotly_version

JuliaPluto · Mar 21, 2024 · ec5c53f · ec5c53f
1 parent dac6e7a
commit ec5c53f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/basics.jl b/src/basics.jl
@@ -54,7 +54,8 @@ end
 
 
 ## Plotly Version ##
-function change_plotly_version(ver::String)
+function change_plotly_version(v)
+	ver = VersionNumber(v)
 	maybe_add_plotly_local(ver)
 	PLOTLY_VERSION[] = ver
 end

diff --git a/test/basic_coverage.jl b/test/basic_coverage.jl
@@ -1,6 +1,6 @@
 using Test
 using PlutoPlotly
-using PlutoPlotly: _preprocess, SKIP_FLOAT32, skip_float32
+using PlutoPlotly: _preprocess, SKIP_FLOAT32, skip_float32, ARTIFACT_VERSION
 using PlutoPlotly.PlotlyBase: ColorScheme, Colors, Cycler, templates
 
 @test SKIP_FLOAT32[] == false
@@ -35,4 +35,8 @@ let p = plot(rand(4))
     @test_throws "invalid keyword arguments" change_image_options!(p; heights = 400)
 end
 
-@test plutoplotly_paste_receiver() isa PlutoPlotly.HypertextLiteral.Result
+@test plutoplotly_paste_receiver() isa PlutoPlotly.HypertextLiteral.Result
+
+@test get_plotly_version() === ARTIFACT_VERSION
+@test change_plotly_version("2.30") === VersionNumber("2.30.0")
+@test get_plotly_version() === VersionNumber("2.30.0")