Merge pull request #25 from giordano/mg/measurements-tag-counter

Fix compatibility issue with `Measurements.jl`
JuliaPhysics · Sep 1, 2022 · 605b9de · 605b9de · giordano · Sep 1, 2022
2 parents fc811ee + feeb3a2
commit 605b9de
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,14 @@
 # History of PhysicalConstants.jl
 
+## v0.2.3 (2022-09-01)
+
+### Bug Fixes
+
+* Fixed compatibility issue with `Measurements.jl` v2.8.0 caused by this package
+  using internal functions non part of the public API
+  ([#24](https://github.com/JuliaPhysics/PhysicalConstants.jl/issues/24),
+  [#25](https://github.com/JuliaPhysics/PhysicalConstants.jl/pull/25)).
+
 ## v0.2.2 (2022-08-22)
 
 ### New Features

diff --git a/Project.toml b/Project.toml
@@ -1,15 +1,15 @@
 name = "PhysicalConstants"
 uuid = "5ad8b20f-a522-5ce9-bfc9-ddf1d5bda6ab"
 authors = ["Mosè Giordano <[email protected]>"]
-version = "0.2.2"
+version = "0.2.3"
 
 [deps]
 Measurements = "eff96d63-e80a-5855-80a2-b1b0885c5ab7"
 Roots = "f2b01f46-fcfa-551c-844a-d8ac1e96c665"
 Unitful = "1986cc42-f94f-5a68-af5c-568840ba703d"
 
 [compat]
-Measurements = "2.0.0"
+Measurements = "2.8.0"
 Roots = "0.8.0, 1.0, 2"
 Unitful = "0.15, 0.16, 0.17, 0.18, 1"
 julia = "1.0.0"

diff --git a/src/PhysicalConstants.jl b/src/PhysicalConstants.jl
@@ -142,7 +142,7 @@ Reference                     = My lab notebook
 """
 macro constant(name, sym, descr, val, def, unit, unc, bigunc, reference)
     ename, qname, esym, qsym, eunit, _bigconvert = _constant_preamble(name, sym, unit, def)
-    tag = Measurements.tag_counters[Base.Threads.threadid()] += 1
+    tag = Threads.atomic_add!(Measurements.tag_counter, UInt64(1))
     quote
        $(_constant_begin(qname, ename, esym, eunit, val, _bigconvert))