Make the package actually usable #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lol, I spoke too soon. EDIT: back in the green 🎉 |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This is necessary since DistributedNext isn't in the default sysimage like Distributed is.
Though a few tests have been disabled because they test things like --worker, which is explicitly unsupported.
JamesWrigley
force-pushed
the
passing-tests
branch
from
7d7ddbf to
50abae9
Compare
Also enables it by default.
Also add Julia 1 to the CI
JamesWrigley
force-pushed
the
passing-tests
branch
from
50abae9 to
56b0b6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR everything's renamed and all the tests pass, plus the
SSHManagertests have been enabled by default on 64bit Linux/OSX since we can use LibSSH.jl to create the SSH server it needs. The SSH tests are kinda heavy though, I don't really know why they create 9 workers by default. If that's annoying I'd be open to lowering it to like 6 or so in the future.The only important change is that the
projectargument must be set correctly if using theSSHManager. I've set it to the currently active project by default, which should at least be a sensible choice for clusters with shared filesystems. I also added a changelog so we can track changes from upstream.I've tried to keep all the commits atomic, so I'd recommend reviewing the PR commit-by-commit.