Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't start watcher during precompile #15

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

jpsamaroo
Copy link
Member

@jpsamaroo jpsamaroo commented Dec 5, 2024

Otherwise precompile hangs because it's waiting on this task to finish.

Otherwise precompile hangs because it's waiting on this task to finish.
@jpsamaroo jpsamaroo marked this pull request as draft December 5, 2024 12:31
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.97%. Comparing base (135f5bd) to head (fecb70d).
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   87.97%   87.97%           
=======================================
  Files          11       11           
  Lines        2070     2071    +1     
=======================================
+ Hits         1821     1822    +1     
  Misses        249      249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@JamesWrigley JamesWrigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to do this anyway. LGTM!

@jpsamaroo jpsamaroo marked this pull request as ready for review December 5, 2024 23:25
@jpsamaroo jpsamaroo merged commit b743ec8 into master Dec 5, 2024
14 checks passed
@jpsamaroo jpsamaroo deleted the jps/no-watcher-precompile branch December 5, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants