Add a watcher mechanism to detect when Distributed might be in use #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesWrigley
force-pushed
the
distributed-warning
branch
from
37bcabd to
ec045ae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10 +/- ##
==========================================
+ Coverage 87.83% 88.06% +0.23%
==========================================
Files 11 11
Lines 2055 2070 +15
==========================================
+ Hits 1805 1823 +18
+ Misses 250 247 -3 ☔ View full report in Codecov by Sentry. |
JamesWrigley
force-pushed
the
distributed-warning
branch
2 times, most recently
from
d1f5989 to
1aefe05
Compare
jpsamaroo
approved these changes
Dec 3, 2024
| @test isempty(stderr_str) | ||
|
|
||
| # Only one of the two being active should also do nothing | ||
| cmd = `$test_exename $test_exeflags -e 'using Distributed, DistributedNext; Distributed.init_multi(); @assert !DistributedNext._check_distributed_active()'` |
There was a problem hiding this comment.
Should we also test the other combination (DistributedNext.init_multi() only)?
There was a problem hiding this comment.
Yeah we might as well, added a test for it in fe0e79a (also took the liberty of cleaning up the test a bit).
This should help users figure out if one of their packages is using Distributed and another is using DistributedNext.
JamesWrigley
force-pushed
the
distributed-warning
branch
from
1aefe05 to
fe0e79a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help users figure out if one of their packages is using Distributed and another is using DistributedNext.