Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type-stable constructorof(::Type{<:NamedTuple})(args...) #17

Merged
merged 3 commits into from
Oct 2, 2019

Conversation

tkf
Copy link
Member

@tkf tkf commented Oct 2, 2019

see #16

@tkf tkf changed the title Type-stable constructorof(::Type{<:NamedTuple{names}})(args...) Type-stable constructorof(::Type{<:NamedTuple})(args...) Oct 2, 2019
@codecov-io
Copy link

codecov-io commented Oct 2, 2019

Codecov Report

Merging #17 into master will increase coverage by 7.14%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #17      +/-   ##
========================================
+ Coverage   92.85%   100%   +7.14%     
========================================
  Files           1      1              
  Lines          14     17       +3     
========================================
+ Hits           13     17       +4     
+ Misses          1      0       -1
Impacted Files Coverage Δ
src/ConstructionBase.jl 100% <100%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee593e5...188b4ca. Read the comment docs.

@jw3126
Copy link
Member

jw3126 commented Oct 2, 2019

LGTM

@tkf tkf merged commit bf245e2 into JuliaObjects:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants