Skip to content

Commit

Permalink
More test simplification. (#95)
Browse files Browse the repository at this point in the history
  • Loading branch information
maleadt authored Sep 23, 2022
1 parent aed52bd commit e907155
Showing 1 changed file with 10 additions and 12 deletions.
22 changes: 10 additions & 12 deletions test/rr.jl
Original file line number Diff line number Diff line change
Expand Up @@ -102,19 +102,17 @@ end
end

# Test that we can upload a trace directory, and replay it.
mktempdir() do temp_srv_dir
Minio.with(; public=true, dir=temp_srv_dir) do conf
creds, bucket = conf
s3_url = "s3://$(bucket.name)/test.tar.zst"
http_url = bucket.baseurl * "test.tar.zst"
endpoint_url = replace(bucket.baseurl, "$(bucket.name)/"=>"")
withenv("S3_ENDPOINT_URL" => endpoint_url) do
BugReporting.upload_rr_trace(temp_trace_dir, s3_url; creds.access_key_id,
creds.secret_access_key, creds.session_token)
end

test_replay(http_url)
Minio.with(; public=true) do conf
creds, bucket = conf
s3_url = "s3://$(bucket.name)/test.tar.zst"
http_url = bucket.baseurl * "test.tar.zst"
endpoint_url = replace(bucket.baseurl, "$(bucket.name)/"=>"")
withenv("S3_ENDPOINT_URL" => endpoint_url) do
BugReporting.upload_rr_trace(temp_trace_dir, s3_url; creds.access_key_id,
creds.secret_access_key, creds.session_token)
end

test_replay(http_url)
end
end

Expand Down

2 comments on commit e907155

@maleadt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/68817

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.2.9 -m "<description of version>" e907155888056dbe5d3a86a9a0e8023f7a56a476
git push origin v0.2.9

Please sign in to comment.