Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade TaylorSeries to v0.18 and TaylorIntegration to v0.16 #171

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

lbenet
Copy link
Member

@lbenet lbenet commented Aug 3, 2024

No description provided.

@lbenet lbenet marked this pull request as ready for review August 3, 2024 23:52
Copy link
Contributor

github-actions bot commented Aug 4, 2024

Pull Request Test Coverage Report for Build 10232509876

Details

  • 353 of 434 (81.34%) changed or added relevant lines in 2 files are covered.
  • 487 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-26.7%) to 53.426%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/valid_integ/validated_integ2.jl 109 142 76.76%
src/valid_integ/validated_integ.jl 244 292 83.56%
Files with Coverage Reduction New Missed Lines %
src/validatedODEs.jl 487 0.0%
Totals Coverage Status
Change from base Build 8638389233: -26.7%
Covered Lines: 1037
Relevant Lines: 1941

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10232509876

Details

  • 353 of 434 (81.34%) changed or added relevant lines in 2 files are covered.
  • 487 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-26.3%) to 53.786%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/valid_integ/validated_integ2.jl 109 142 76.76%
src/valid_integ/validated_integ.jl 244 292 83.56%
Files with Coverage Reduction New Missed Lines %
src/validatedODEs.jl 487 0.0%
Totals Coverage Status
Change from base Build 8638389233: -26.3%
Covered Lines: 1037
Relevant Lines: 1928

💛 - Coveralls

@coveralls
Copy link

coveralls commented Aug 4, 2024

Pull Request Test Coverage Report for Build 12995972981

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 355 of 434 (81.8%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.1%) to 78.054%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/valid_integ/validated_integ2.jl 109 142 76.76%
src/valid_integ/validated_integ.jl 246 292 84.25%
Totals Coverage Status
Change from base Build 8638389233: -2.1%
Covered Lines: 1035
Relevant Lines: 1326

💛 - Coveralls

@lbenet
Copy link
Member Author

lbenet commented Aug 15, 2024

Closes #159 and #160

@lbenet
Copy link
Member Author

lbenet commented Aug 15, 2024

The test that fails (only in Julia 1.6) is related to an ambiguity detected by Aqua; I'll ignore it for the time being...

@schillic
Copy link
Contributor

Closes #159 and #160

FYI, if you want to auto-close these PRs, you need to put this text in the very first post. And GitHub does not understand "and", so you need to write "Closes" twice.

@lbenet
Copy link
Member Author

lbenet commented Aug 15, 2024

Closes #159 and #160

FYI, if you want to auto-close these PRs, you need to put this text in the very first post. And GitHub does not understand "and", so you need to write "Closes" twice.

Thanks a lot for clarifying it!

@lbenet
Copy link
Member Author

lbenet commented Jan 27, 2025

Mmmm, there seems to be some odity related to coveralls...

@schillic
Copy link
Contributor

Mmmm, there seems to be some odity related to coveralls...

I have no experience with coveralls (we always use codecov). The error message is indeed not helpful.

Fixing the cause would of course be better, but maybe you can add the following line inside the with block here:

- uses: coverallsapp/github-action@master
with:
path-to-lcov: lcov.info
github-token: ${{ secrets.GITHUB_TOKEN }}

fail_ci_if_error: false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants