This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
WIP: New interface proposal for numerical formatting: fmt and fmt_default! #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change the title to start with WIP:, that seems to be the convention, so people know that it is a work in progress. |
tbreloff
changed the title
|
I'm philosophically ok with "yet another formatting api" as in cfmt. The symbol argument list is an acceptable alternative to the keyword arguments. Could you edit the README.md to advertise this properly? |
|
This package is no longer maintained (see #111). Please consider using Format.jl instead, and if this feature is unavailable / still desired, open an issue or PR there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't intend this to be merged as-is, but I want to start a discussion as to whether this approach will make sense. See the embedded TODO's for some ways that I would expect a final version to be different. You can see some example usage in tests/fmt.jl. Let me know your comments, and please... be brutal.